Skip to content

Conversation

@shangm2
Copy link
Contributor

@shangm2 shangm2 commented Nov 1, 2025

Summary: as titled

Differential Revision: D85927678

@netlify
Copy link

netlify bot commented Nov 1, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit e5ee480
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/6914c8f836a28e0008887a4e

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 1, 2025

@shangm2 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85927678.

shangm2 added a commit to shangm2/velox that referenced this pull request Nov 1, 2025
…nning drivers per operator and expose existing ioWaitWallNanos for per-operator aggregation (facebookincubator#15354)

Summary:
Pull Request resolved: facebookincubator#15354

as titled

Differential Revision: D85927678
@shangm2 shangm2 changed the title Add runtime metric to find the max cpu time of running drivers per operator and expose existing ioWaitWallNanos for per-operator aggregation misc(runtimestats): Add runtime metric to find the max cpu time of running drivers per operator and expose existing ioWaitWallNanos for per-operator aggregation Nov 1, 2025
@shangm2 shangm2 changed the title misc(runtimestats): Add runtime metric to find the max cpu time of running drivers per operator and expose existing ioWaitWallNanos for per-operator aggregation misc(runtimestats): Add runtime metric to find the max cpu time of running drivers per operator and expose existing ioWaitWallNanos Nov 1, 2025
shangm2 added a commit to shangm2/velox that referenced this pull request Nov 1, 2025
…nning drivers per operator and expose existing ioWaitWallNanos (facebookincubator#15354)

Summary:

as titled

Differential Revision: D85927678
@shangm2 shangm2 force-pushed the export-D85927678 branch 2 times, most recently from 51f4715 to d9e60e2 Compare November 4, 2025 22:43
shangm2 added a commit to shangm2/velox that referenced this pull request Nov 4, 2025
…nning drivers per operator and expose existing ioWaitWallNanos (facebookincubator#15354)

Summary:

as titled

Differential Revision: D85927678
shangm2 added a commit to shangm2/velox that referenced this pull request Nov 7, 2025
…nning drivers per operator and expose existing ioWaitWallNanos (facebookincubator#15354)

Summary:
Pull Request resolved: facebookincubator#15354

as titled

Reviewed By: arhimondr

Differential Revision: D85927678
…nning drivers per operator and expose existing ioWaitWallNanos (facebookincubator#15354)

Summary:
Pull Request resolved: facebookincubator#15354

as titled

Reviewed By: arhimondr

Differential Revision: D85927678
@shangm2 shangm2 requested a review from xiaoxmeng November 12, 2025 19:00
Copy link
Contributor

@tanjialiang tanjialiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM %nits

"queuedWallNanos",
"flushTimes"};
"flushTimes",
"driverCpuTimeNanos",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we use the defined constant? If possible we can make other entries to reuse their corresponding defined constants as well.

@meta-codesync
Copy link

meta-codesync bot commented Nov 12, 2025

@shangm2 has imported this pull request. If you are a Meta employee, you can view this in D85927678.

@meta-codesync
Copy link

meta-codesync bot commented Nov 13, 2025

@shangm2 merged this pull request in c746114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants